Allow User to Specify Max Connections to DB #37748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
|
Hi @crobert-1 , I wanted to run integration test locally but when trying I am facing the following issue:
Do I have to do something extra for this? |
Integration tests have a go build tag (the tag is integration). They're only run if the proper tag is included in the build and test command. You should be able to do |
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
|
Hi @dashpole , gentle ping for this PR review. Also, the failing test doesn't seem to be caused by the PR changes. |
atoulme
reviewed
Feb 12, 2025
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
akstron
force-pushed
the
sql-receiver-connection-pool
branch
from
a8e5616 to
a5a0f59
Compare
|
Hi @atoulme , following up on this PR. Let me know if there are any more comments on this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added additional field
MaxOpenConnwhich allow users to specify the maximum number of connections to DB server.Link to tracking issue
Fixes: #36752
Testing
TestMysqlIntegrationMetrics