[exporter/syslog] Fix handling of multiple structured data elements #37927
+95
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current syslog exporter does not handle structured data well. In particular, when there is more than one structured data field, it will put them all in one structured data block rather than in one block per field as the RFC5424 suggests. This test is a test for this error.
…ata block is built up as its own array (rather than as one single array as it was done before). String builder (strings.Builder) was used to buffer the final string that is built up.
|
Hello @peffis, thanks for your contribution! To be able to move this PR forward the CLA must be signed. Feel free to reach out if you have any questions! |
I think (hope) that is checked off now (took some time for me to get clearance from my company admins) |
rnishtala-sumo
approved these changes
Feb 25, 2025
andrzej-stencel
approved these changes
Mar 6, 2025
andrzej-stencel
changed the title
andrzej-stencel
changed the title
andrzej-stencel
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported in issue #33300 this fixes the issue when there are more than one structured data block in the structured_data attributes object. Say you had a structured block like this:
{ "structured_data": { "a@123": { "a": "123" }, "b@321": { "b": "321" } } }The expected output would then be two sd blocks, like [a@193 a="123"][b@193 b="321"]
, but instead the code returns one array, like [a@193 a="123" b@193 b="321"] which is wrong according to the
RFC5424
Link to tracking issue
Fixes #33300
Testing
A new test for "more than one SD field" was added in the commit, which failed for the original code, but passes now with the fix.
Documentation
No documentation change needed.