Use serializer exporter for sending metrics #37930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ankitpatel96,
IbraheemA,
jade-guiton-dd,
liustanley,
mackjmr,
mx-psi and
songy23
songy23
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Can you add a test case using serializer to integration test? e.g. http://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/datadogexporter/integrationtest/integration_test.go#L546
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
…-serializer-exporter
songy23
reviewed
Mar 3, 2025
| @@ -133,7 +133,7 @@ func (exp *logsExporter) consumeLogs(ctx context.Context, ld plog.Logs) (err err | |||
| } | |||
| } | |||
|
|
|||
| payloads := exp.translator.MapLogs(ctx, ld, nil) | |||
| payloads := exp.translator.MapLogs(ctx, ld, attributes.NewGatewayUsage()) | |||
…-serializer-exporter
…-serializer-exporter
songy23
approved these changes
Mar 4, 2025
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
…-serializer-exporter
…-serializer-exporter
|
need another rebase / merge main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds feature-gate
exporter.datadogexporter.metricexportserializerclient. When enabled DDexporter would use serializerexporter for exporting metricsLink to tracking issue
Fixes
Testing
Documentation