[chore] make checkapi a module, adding a metadata.yaml #37945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
make_checkapi_a_module
branch
from
91bd7a1 to
2793fcf
Compare
dehaansa
approved these changes
Feb 15, 2025
dehaansa
previously requested changes
Feb 15, 2025
There was a problem hiding this comment.
Seeing
go: warning: "./..." matched no packages
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
no Go files in /Users/dehaansa/go/src/github.com/open-telemetry/opentelemetry-collector-contrib
Whenever I run a make task on this branch. Rescinding approval while I take a look.
Edit: Nothing discovered that makes any sense here. Happy to treat this as a "my machine" issue if someone else approves. On macOS sequoia, this behavior doesn't happen for me on other branches, I pulled a few other PRs to check.
|
I see it too. It's to do with how the checkapi binary is built, probably within the wrong working directory. I will look into this more. |
|
Let's get #37951 in first, this PR has brought in unexpected issues. |
MovieStoreGuy
pushed a commit
that referenced
this pull request
Feb 19, 2025
…up (#37951) This change is brought about by the realization that with #37945 no code is directly under the root module. This has the unexpected impact that some of the Makefile set up started to show warnings. It turns out that we do quite a bit of reading files and go packages in the Makefile. This has a performance impact. We also have incorrect code in there, such as the computation of `ALL_PKG_DIRS` only returns `github.com/open-telemetry/opentelemetry-collector-contrib/cmd/checkapi`.
atoulme
force-pushed
the
make_checkapi_a_module
branch
from
5dd9687 to
cea322f
Compare
|
@dehaansa ready for another look |
MovieStoreGuy
approved these changes
Feb 23, 2025
atoulme
force-pushed
the
make_checkapi_a_module
branch
2 times, most recently
from
94a20df to
8d6b37a
Compare
atoulme
force-pushed
the
make_checkapi_a_module
branch
from
8d6b37a to
7105a89
Compare
dehaansa
reviewed
Mar 4, 2025
Co-authored-by: Sam DeHaan <dehaansa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the checkapi tool a go module with a metadata.yaml.