[opampsupervisor] add telemetry settings to the opamp supervisor #38017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
# Conflicts: # cmd/opampsupervisor/go.mod # cmd/opampsupervisor/go.sum
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
# Conflicts: # cmd/opampsupervisor/go.mod # cmd/opampsupervisor/go.sum
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
# Conflicts: # cmd/opampsupervisor/go.mod # cmd/opampsupervisor/go.sum
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
# Conflicts: # cmd/opampsupervisor/go.mod # cmd/opampsupervisor/go.sum # cmd/opampsupervisor/supervisor/supervisor.go
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
evan-bradley
reviewed
Mar 4, 2025
evan-bradley
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds options to configure the telemetry settings for the OpAmp supervisor. This will enable the supervisor, in addition to logging, export metrics and traces as well. For the sake of consistency, I also moved the logger of the supervisor into the telemetrySettings property of the supervisor.
This PR does not add any traces or metrics yet, but just provides the groundwork to add those later on.
Link to tracking issue
Fixes #35582
Testing
Added Unit tests. E2E test can be added once we start emitting traces and metrics.