Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/servicegraph] Remove "_seconds" from metric names #38033

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Feb 18, 2025

Keeping the docs up to date after #34511

@atoulme
Copy link
Contributor

atoulme commented Feb 21, 2025

Please add a changelog as a breaking change.

@ptodev ptodev force-pushed the spanmetrics-unit-docs branch from 677e813 to 7f8019d Compare March 5, 2025 14:13
@ptodev
Copy link
Contributor Author

ptodev commented Mar 5, 2025

@atoulme this PR is just documenting a breaking change which was released a few months ago. The original change does contain a "breaking change" changelog entry.

@dehaansa dehaansa added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry ready to merge Code review completed; ready to merge by maintainers labels Mar 5, 2025
@atoulme atoulme merged commit 7c2c30a into open-telemetry:main Mar 5, 2025
160 of 166 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/servicegraph documentation Improvements or additions to documentation ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants