Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webhookeventreceiver] allow multiple logs per request #38042

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

mterhar
Copy link
Member

@mterhar mterhar commented Feb 18, 2025

Description

Add a configuration that allows users to choose the original behavior or the newer multi-line behavior.

Link to tracking issue

Fixes #38037

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels appropriate to me. The transformprocessor would not be able to handle breaking the single log into new logs without a fancy new function. Doing it in the receiver feels more appropriate.

@shalper2
Copy link
Contributor

I think this makes sense. One request though -- could you add a little more context to the README? I don't think its clear to someone who's never used the receiver before how this setting changes the default behavior.

@mterhar mterhar force-pushed the webhook-receiver-multiple-logs branch from 914f2b1 to a24c223 Compare March 3, 2025 18:10
@mterhar
Copy link
Member Author

mterhar commented Mar 3, 2025

I think this makes sense. One request though -- could you add a little more context to the README? I don't think its clear to someone who's never used the receiver before how this setting changes the default behavior.

@shalper2 Does the updated readme have sufficient info without going overboard?

@shalper2
Copy link
Contributor

shalper2 commented Mar 3, 2025

Thats great, thank you!

@atoulme atoulme merged commit fa68fc0 into open-telemetry:main Mar 3, 2025
156 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/webhookevent] Allow multiple lines via configuration
4 participants