[chore] processor/deltatocumulative: data.Adder #38058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh0rez
changed the title
dehaansa
reviewed
Feb 19, 2025
sh0rez
force-pushed
the
adder
branch
2 times, most recently
from
a1f21db to
97a65e9
Compare
Introduces data.Adder, a struct that performs adding of pmetric.*DataPoint. This opens up future features that require configuration of the adding operation, such as out of order support.
moves timestamp handling from internal/data.Adder to internal/delta.Aggregate, as it arguably belongs there.
dehaansa
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces data.Adder, a struct that performs adding of pmetric.*DataPoint.
This opens up future features that require configuration of the adding operation, such as out of order support.
Testing
Existing tests pass unaltered