[googlecloudexporter] use new exporter creator args #38116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the Google Cloud Exporter dependency and makes the necessary API change.
github-actions
bot
added
exporter/googlecloud
exporter/googlemanagedprometheus
|
operations-go was just released: https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/releases/tag/v0.51.0 |
braydonk
changed the title
aabmass
approved these changes
Mar 3, 2025
jsuereth
approved these changes
Mar 3, 2025
dehaansa
approved these changes
Mar 3, 2025
dehaansa
added
the
ready to merge
songy23
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Google Cloud Exporter dependency and makes the necessary API change.
Stating here for posterity, what the new release of
opentelemetry-operations-gowill do is accept a fullexporter.Settingsso it can use thecomponent.BuildInfoto construct a more reasonable fallback User Agent string (matching what the OTLP exporters do). This should have no user-facing effect.Link to tracking issue
Fixes no open issue
Testing
UPDATE: See testing method here https://gist.github.com/braydonk/620580d02e5b6c61f0bf3a96ac2055de
Tested locally with
go replace, but will redo when the new release ofopentelemetry-operations-gois cut and I point to that.Documentation
No user-facing changes.