-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add SAPM deprecation metadata #38144
[chore] add SAPM deprecation metadata #38144
Conversation
Shall we ignore the metadata validation failure for now?
|
I was hoping the yaml deserializer would be ok with additional fields. Now we have to synchronize all the PRs. I will make a change to mdatagen to ignore additional fields, then we can update mdatagen, then we can roll this up. |
open-telemetry/opentelemetry-collector#12484 is open to attend to this. |
Why do we want add new fields that are not being used? |
You can see the issue here: open-telemetry/opentelemetry-collector#12464 |
Makes sense. Why don't implement it first instead of open-telemetry/opentelemetry-collector#12484? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdatagen checks succeed now. LGTM
Description
See open-telemetry/opentelemetry-collector#12359
Add more deprecation metadata to the sapm components.