[chore] enable running ARM builds by default #38204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hostmetrics tests should be fixed in #38211 |
mowies
approved these changes
Mar 4, 2025
|
Connecting the issue for the failing test because it's not linked and I keep losing track of it: #38205 |
atoulme
pushed a commit
that referenced
this pull request
Mar 6, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Update the metric_calculator_test's TestSweep to not test the behavior
of the internal go timer in a way that causes arm tests to fail.
On linked issue, I added these comments to the existing test to describe
the existing behavior, this PR drops the last assert and causes the
existing assert to check that the passed clock time is greater than the
expected amount of TTLs, which appears to be the original intent.
```
for i := 1; i <= 2; i++ {
// sweepTime is the time that the internal ticker _expected_ to tick, may not be close (1ms) to the current time
sweepTime := <-sweepEvent
// tickTime is the time since test start plus the # of expected ticks
tickTime := time.Since(start) + mwe.ttl*time.Duration(i)
require.False(t, closed.Load())
// This is asserting that the ttl is less than or equal to the time since the start captured before the mwe.sweep function was called,
// so it's asserting that time consumed until now is greater than one ttl. Should probably be ttl * i, and tickTime should just be time.Since(start)
assert.LessOrEqual(t, mwe.ttl, tickTime)
// This is asserting that the time since the _expected_ current tick time is less than or equal to the ttl.
// This is just testing if the internal timer got to schedule its tick well, and isn't late? This is go runtime behavior, not MWE behavior.
assert.LessOrEqual(t, time.Since(sweepTime), mwe.ttl)
}
```
<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
#38205
Relevant to
#38204
dehaansa
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run ARM builds on any PR.
Link to tracking issue
Fixes #38198