[chore][pkg/ottl] Split package ctxutil #38246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
edmocosta,
evan-bradley,
kentquirk and
TylerHelmuth
djaglowski
force-pushed
the
ottl-split-ctxutil
branch
from
a6ac943 to
27f799c
Compare
TylerHelmuth
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ctxcommonpackage alongsidectxutil. I found while working on #38239 that circular dependencies became a problem. With this change,ctxutilis dedicated to generic accessors for different data types, whilectxcommoncontains more specific functionality that is shared by multiple contexts. e.g. resource and scope share SchemaURL, logs and traces share trace/span ID parsing.