[chore][pkg/stanza] - finalize archive's implementation #38267
+119
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VihasMakwana
force-pushed
the
tracker-final
branch
from
0074e35 to
996c687
Compare
VihasMakwana
force-pushed
the
tracker-final
branch
from
996c687 to
41dc51c
Compare
|
One thing remains i.e. to update |
VihasMakwana
added
the
Skip Changelog
|
I'll add changelog in documentation PR, as that will enable the actual config. |
VihasMakwana
force-pushed
the
tracker-final
branch
from
c4f722b to
9a102d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes the archive implementation and adds test case.
@djaglowski I think we can add more sophisticated test cases once we establish common ground on the implementation.
Relates: #38056