fix: healthcheckv2extension: fix deadlock in case of an error in http server start #38269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lim123123123
requested review from
jpkrohling,
mwear and
a team
as code owners
lim123123123
force-pushed
the
k.garmanov/healthcheckv2-shutdown-fix
branch
from
fbf5cb3 to
215d8af
Compare
atoulme
approved these changes
Mar 5, 2025
|
I've added the changelog entry, and also have fixed the linter. Could you re-review? @atoulme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation uses a channel for graceful shutdown, but it doesn't work in case of an error during socket binding. Since the goroutine that writes to that channel is never created, it causes a deadlock in Shutdown.
This is a minor issue, but it annoys me. Each time I forget to shut down the previous debug session, the new one freezes (since the address is already in use, causing an error in Start).
Link to tracking issue
Fixes
Since this is a really small problem, I didn't create an issue. Let me know if it's required, and I'll create one.
Testing
I've added a unit test that fails with the current implementation but works with the fix.