[extension/ecsobserver] Fix missing task tags retrieval #38278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlsgiga
changed the title
ddmunhoz
approved these changes
Feb 28, 2025
|
Please add a changelog |
pjanotti
approved these changes
Feb 28, 2025
|
Changelog added! 🙌🏻 |
songy23
approved these changes
Mar 1, 2025
|
Any chance we can get this in the next release? |
pjanotti
approved these changes
Mar 3, 2025
pjanotti
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ecsobserverextension is not complying with the latest ECS DescribeTask API specs as it does not define the introducedInclude: ["TAGS"]option.This causes the
ecsobserverto not render the__meta_ecs_task_tags_*labels on scraping since the Task Tags are not being included in the API response.This is preventing us from enriching our metrics with Task Tags.
Testing
Added a test to validate that Task Tags are included in the response.