-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] add MarshalLogObject
to ottlmetric
context
#38293
[pkg/ottl] add MarshalLogObject
to ottlmetric
context
#38293
Conversation
MarshalLogObject
for ottlmetric
context
MarshalLogObject
for ottlmetric
contextMarshalLogObject
to ottlmetric
context
2faac0b
to
9c0f794
Compare
@@ -191,6 +191,18 @@ func (m Metric) MarshalLogObject(encoder zapcore.ObjectEncoder) error { | |||
return err | |||
} | |||
|
|||
type MetricSlice pmetric.MetricSlice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can revert this change as we don't need it anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep it just for potential future use? It does not hurt to have an interface implemented for the MetricSlice, even if it's not used now, things can change in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an internal package, and IMO, if we don't have any usages/plans for that implementation at the moment, we should just drop it, and add it when/if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then, removed
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Co-authored-by: Edmo Vamerlatti Costa <11836452+edmocosta@users.noreply.github.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
71aaac1
to
11abbd5
Compare
For reference, here's an example of a debug log before and after this change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for implementing it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to rebase / merge main
Link to tracking issue
Fixes #38103