[receiver/awsecscontainermetrics] Aggregate I/O metrics from all devices #38309
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnangle
force-pushed
the
awsmetrics-io-aggregate
branch
from
428a7c9 to
a971ffa
Compare
atoulme
approved these changes
Mar 4, 2025
@evan-bradley are you able to help with this please? |
|
@jonnangle unfortunately I don't have the proper understanding of this component to confidently review this. @Aneurysm9 could you take a look as the code owner? |
|
@Aneurysm9 I've rebased this - are you able to help with an approval please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the storage.read_bytes and storage.write_bytes metrics include the i/o counts from all devices listed in
blkio_stats.io_service_bytes_recursive.Link to tracking issue
Fixes #38301
Testing
I've extended the existing test condition to cover this general case.