[connector/routing] Add support for standard converter functions in routing conditions #38312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmikei
commented
Mar 4, 2025
Comment on lines
19
to
26
| func Functions[K any]() map[string]ottl.Factory[K] { | ||
| return ottl.CreateFactoryMap( | ||
| ottlfuncs.NewIsMatchFactory[K](), | ||
| ottlfuncs.NewIsMapFactory[K](), | ||
| ottlfuncs.NewIsStringFactory[K](), | ||
| ottlfuncs.NewDeleteKeyFactory[K](), | ||
| ottlfuncs.NewDeleteMatchingKeysFactory[K](), | ||
| // noop function, it is required since the parsing of conditions is not implemented yet, |
There was a problem hiding this comment.
Suggested change
| func Functions[K any]() map[string]ottl.Factory[K] { | |
| return ottl.CreateFactoryMap( | |
| ottlfuncs.NewIsMatchFactory[K](), | |
| ottlfuncs.NewIsMapFactory[K](), | |
| ottlfuncs.NewIsStringFactory[K](), | |
| ottlfuncs.NewDeleteKeyFactory[K](), | |
| ottlfuncs.NewDeleteMatchingKeysFactory[K](), | |
| // noop function, it is required since the parsing of conditions is not implemented yet, | |
| func Functions[K any]() map[string]ottl.Factory[K] { | |
| return ottlfuncs.StandardConverters[K]() | |
| } |
I could also see this being an implementation choice, I'll leave it up to the maintainers here if they think that is too much!
There was a problem hiding this comment.
I think the routing connect should have access to all converters. This is safe since converters never change the underlying telemetry itself. @jpkrohling, @mwear @djaglowski do you agree?
…tor-contrib into feat/add-routing-ismatch-isStr
…opentelemetry-collector-contrib into feat/add-routing-ismatch-isStr
schmikei
changed the title
IsMap and IsString as supported OTTL functions
schmikei
changed the title
dehaansa
reviewed
Mar 6, 2025
dehaansa
approved these changes
Mar 6, 2025
dehaansa
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just adding to the factory of the routing connector to include some useful for routing OTTL functions. Let me know if I'm overlooking anything as this is my first contribution to the routing connector!
Link to tracking issue
Resolves #38282
Testing
Tested with the three signals conditions on Logs, Metrics and Traces
Documentation
Updated the list of OTTLFuncs supported in the README