Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricstarttimeprocessor: Use hash of resource attributes for StartimeCache #38326

Merged

Conversation

ridwanmsharif
Copy link
Member

Description

This change decouples the processor from the prometheus receiver concepts. It uses a hash of all resource attributes for the StartTimeCache instead of the job and instance labels.

Link to tracking issue

Fixes #38286.

Testing

Updated unit tests.

Documentation

N/A

@ridwanmsharif
Copy link
Member Author

cc @jmacd

@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/resource-hash branch 2 times, most recently from f87c80f to 49bc987 Compare March 4, 2025 02:44
…meCache

Fixes open-telemetry#38286.

This change decouples the processor from the prometheus receiver
concepts.

Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
@ridwanmsharif ridwanmsharif force-pushed the ridwanmsharif/resource-hash branch from 49bc987 to 3bbf1ef Compare March 4, 2025 06:46
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme merged commit d4e0421 into open-telemetry:main Mar 4, 2025
156 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 4, 2025
@ridwanmsharif ridwanmsharif deleted the ridwanmsharif/resource-hash branch March 4, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[metricstarttimeprocessor] Identify resource by hash of all attributes
4 participants