googlecloudexporter: add ability to write to custom MRs #38331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
requested review from
dashpole,
jsuereth and
a team
as code owners
ridwanmsharif
force-pushed
the
ridwanmsharif/custom-monitored-resources
branch
from
138a97e to
4eb5864
Compare
Fixes open-telemetry#38102 This change adds a featuregate that allows writing to custom monitored resources based on presence of the `gcp.resource_type` resource attribute. The default mapping from OTel resources to MRs are used as a fallback. To enable it, use the `exporter.googlecloud.CustomMonitoredResources` featuregate. Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
force-pushed
the
ridwanmsharif/custom-monitored-resources
branch
from
4eb5864 to
6434f68
Compare
jsuereth
approved these changes
Mar 4, 2025
aabmass
approved these changes
Mar 4, 2025
| resource: func() pcommon.Resource { | ||
| r := pcommon.NewResource() | ||
| r.Attributes().PutStr("gcp.resource_type", "custom_resource") | ||
| r.Attributes().PutStr("gcp.custom_resource.label1", "value1") |
There was a problem hiding this comment.
There is a chance of future collision with MR types and the GCP resource conventions https://github.com/open-telemetry/semantic-conventions/tree/main/docs/resource/cloud-provider/gcp
Maybe a non issue but wanted to call it out
There was a problem hiding this comment.
The collision should not happen for custom resources since they will not be a part of the semconv. However care must be taken that strings used to represent custom MR are different from those defined in semconv.
psx95
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a featuregate that allows writing to custom monitored resources based on presence of the
gcp.resource_typeresource attribute.The default mapping from OTel resources to MRs are used as a fallback.
To enable it, use the
exporter.googlecloud.CustomMonitoredResourcesfeaturegate.Link to tracking issue
Fixes #38102
Testing
Added unit tests
Documentation
N/A