-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Remove deprecated macos-12 runner, Add macos-15 runner #38337
[chore] Remove deprecated macos-12 runner, Add macos-15 runner #38337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kinda confusing. Why are you building with 14 and 15 but then only uploading 14 and then using that on 13 only?
@atoulme or somebody else with permissions, could you please add the "run darwin" label to run the MacOS unit tests? |
The original workflow copies artifacts from versions 14 to 12 and 13 to verify that the built binary works correctly in older versions. I've added macOS-15 to ensure tests pass on this version, while only uploading artifacts for version 14 to confirm that the legacy workflow remains functional. There are some hard-coded elements in the Makefile related to the tests in this workflow. I haven't spent more time on this because I'm uncertain if the workflow makes sense, as my main objective with this PR is to resolve the hanging job issue on the main branch. |
ok thanks for the explainer. anyways, i think something needs to be changed since macos-13 is x86 and macos-{14,15} is ARM based so I'm not sure if that will work. But nothing is certain until the unit tests are triggered :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the darwin tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it works, it works i guess :D
Description
ref: actions/runner-images#10721
Link to tracking issue
n/a
Testing
n/a
Documentation
n/a