[processor/k8sattributes] support extracting labels and annotations from Deployments #38343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ChrsMark,
dmitryax,
fatsheep9146 and
TylerHelmuth
odubajDT
force-pushed
the
k8sattributes-processor-workload-informers
branch
2 times, most recently
from
aff9e65 to
cad5b00
Compare
odubajDT
changed the title
odubajDT
force-pushed
the
k8sattributes-processor-workload-informers
branch
3 times, most recently
from
7a3bd1f to
f1745c9
Compare
odubajDT
changed the title
odubajDT
commented
Mar 12, 2025
| newInformer InformerProvider, | ||
| newNamespaceInformer InformerProviderNamespace, | ||
| newReplicaSetInformer InformerProviderReplicaSet, | ||
| informersFactory InformersFactoryList, |
There was a problem hiding this comment.
small refactoring for potential future extensions
odubajDT
commented
Mar 12, 2025
| @@ -478,14 +547,10 @@ func (c *WatchClient) extractPodAttributes(pod *api_v1.Pod) map[string]string { | |||
| if c.Rules.StartTime { | |||
| ts := pod.GetCreationTimestamp() | |||
| if !ts.IsZero() { | |||
| if enableRFC3339Timestamp.IsEnabled() { | |||
There was a problem hiding this comment.
the feature gate is already in stable phase, therefore there is no possibility to disable it, therefore this if-else statement is unneeded, as the else branch is unreachable
… workloads Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
odubajDT
force-pushed
the
k8sattributes-processor-workload-informers
branch
from
e9e79c1 to
87e27be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for extraction of labels and annotations from Deployments. This change comes with elevated RBAC permissions - adding Deployment permissions to the ClusterRole
Link to tracking issue
Fixes #37957