Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(faro-1): Wireframe for faro receiver #38345

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

dark0dave
Copy link
Contributor

@dark0dave dark0dave commented Mar 4, 2025

Signed-off-by: dark0dave dark0dave@mykolab.com

Description

Link to tracking issue

#19180

Testing

Documentation

Related: #38224

@dark0dave dark0dave changed the title feat(faro-1): First pr for faro receiver feat(faro-1): Wireframe for faro reciever Mar 4, 2025
@dark0dave
Copy link
Contributor Author

@dehaansa #38224 (comment)

@dark0dave dark0dave force-pushed the feature/faro-1 branch 3 times, most recently from be6c358 to ae8cfc8 Compare March 4, 2025 16:12
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Mar 4, 2025
@dark0dave dark0dave force-pushed the feature/faro-1 branch 2 times, most recently from 2141a2d to f1f21ca Compare March 4, 2025 16:15
@dark0dave dark0dave marked this pull request as ready for review March 4, 2025 16:15
@dark0dave dark0dave requested a review from a team as a code owner March 4, 2025 16:15
@dark0dave dark0dave requested a review from crobert-1 March 4, 2025 16:15
@dehaansa dehaansa requested review from a team and removed request for ankitpatel96, songy23, IbraheemA, liustanley, MovieStoreGuy, mackjmr and jade-guiton-dd March 4, 2025 22:05
@dark0dave dark0dave force-pushed the feature/faro-1 branch 2 times, most recently from a962291 to 85eb479 Compare March 5, 2025 16:27
@dark0dave
Copy link
Contributor Author

@dehaansa contrib removed anything else required to land this?

@dehaansa
Copy link
Contributor

dehaansa commented Mar 5, 2025

@dehaansa contrib removed anything else required to land this?

Merge in main to fix the codeowners check, and I believe make gotidy will clean up the other two checks.

@dark0dave
Copy link
Contributor Author

@dehaansa contrib removed anything else required to land this?

Merge in main to fix the codeowners check, and I believe make gotidy will clean up the other two checks.

On it!

@dehaansa
Copy link
Contributor

dehaansa commented Mar 5, 2025

CI said something about make generate being out of date as well.

@dark0dave
Copy link
Contributor Author

CI said something about make generate being out of date as well.

Ok, looking thank you.

@dark0dave dark0dave force-pushed the feature/faro-1 branch 5 times, most recently from ecc0b30 to df5bfb9 Compare March 5, 2025 20:08
Signed-off-by: dark0dave <dark0dave@mykolab.com>
@dehaansa dehaansa added the ready to merge Code review completed; ready to merge by maintainers label Mar 5, 2025
@atoulme atoulme merged commit 96d757d into open-telemetry:main Mar 5, 2025
167 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 5, 2025
@dark0dave dark0dave deleted the feature/faro-1 branch March 6, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Component New component has been sponsored ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants