[receiver/awsfirehose] remove error logging on gzip.Reader type assertion failure due to nil value #38352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug.
We see a lot of error logs after upgrading
opentelemetry-collector-contrib
to 0.120.0:The root cause is that the type assertion in the following code could return
ok=false
whenr
isnil
. This could happen when the marshaller is instantiated and there's no value ingzipPool
yet.This PR removes the error log. Since we are instantiating the reader only in the line right below
I don't think checking the type assertion result and logging an error is really necessary.