Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/otlpjsonfile][bugfix] only add attributes if record/span/metric count is greater than 0 #38354

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

VihasMakwana
Copy link
Contributor

Description

Fix nil pointer dereference due to empty token

Link to tracking issue

Fixes #38289

Testing

Added test which fails without the fix in place.

@VihasMakwana VihasMakwana requested a review from djaglowski March 4, 2025 16:02
@atoulme atoulme merged commit 84bea87 into open-telemetry:main Mar 4, 2025
156 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference with log files larger than 1 MB
3 participants