[cmd/opampsupervisor] add ability to report own traces/logs #38360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the supervisor to configure capability to configure both traces and logs for the collector's own telemetry via OTLP, the same way it is enabled for metrics. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
requested review from
evan-bradley,
atoulme,
tigrannajaryan and
a team
as code owners
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
TylerHelmuth
approved these changes
Mar 4, 2025
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
evan-bradley
approved these changes
Mar 4, 2025
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the supervisor to configure capability to configure both traces and logs for the collector's own telemetry via OTLP, the same way it is enabled for metrics.
To accomplish this I ended up updating the code that stores own telemetry as a TelemetryConnectionSettings to storing a
ConnectionSettingsOffersthat includes all 3 signals.