[chore] docker observer: Ensure routines are managed without storing context #38378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
force-pushed
the
msg/ensure-controlled-routines
branch
from
cc26f63 to
3422e8a
Compare
MovieStoreGuy
added
the
Skip Changelog
MovieStoreGuy
changed the title
dmitryax
reviewed
Mar 5, 2025
| once *sync.Once | ||
| ctx context.Context | ||
| cancel context.CancelFunc | ||
| wg errgroup.Group |
There was a problem hiding this comment.
Do we still need to store cancel? We can probably initialize wg using WithContext instead
There was a problem hiding this comment.
So looking at the errgroup in more detail, when initialised with errgroup.WithContext, the group.Wait method will first wait for all routines to finish and then call cancel.
In this scenario, we need it the other way around so that the routines are shutdown and then wait for the routines to cleanly stop.
atoulme
reviewed
Mar 5, 2025
atoulme
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows the go practice of avoiding storing context as part of a structure and passing it through method invocations.
Link to tracking issue
Fixes NA
Testing
This should keep the same behaviour
Documentation
Transparent user change, not added.