Add subtract_initial_point strategy skeleton #38380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
subtract_initial_point
branch
from
52e8c4d to
a1e410d
Compare
ridwanmsharif
approved these changes
Mar 5, 2025
| Pros: | ||
|
|
||
| * Cumulative semantics are preserved. This means that for a point with a given `[start, end]` interval, the cumulative value occurred in that interval. | ||
| * Rates over resulting timeseries are correct, even if points are lost. This strategy is not stateful. |
There was a problem hiding this comment.
is this last bit true? we still need to store the previous value of the timeseries to detect resets, and also the initial point timestamp for every subsequent point.
There was a problem hiding this comment.
What I mean is that the sequence of resulting points isn't stateful. Each point is meaningful on its own, as it gives you a correct average rate over the interval.
I'm trying to contrast it with the true_reset_point strategy. If you lose the initial "true reset" point, you will interpret subsequent points incorrectly.
Feel free to suggest wording or framing that makes more sense to you.
atoulme
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a skeleton for the
subtract_initial_pointstrategy. The implementation will follow in subsequent PRs.Link to tracking issue
Part of #37186, and #38379
Testing
Added config_test.go
Documentation
Updated the README.