[exporter/prometheusremotewrite] Add endpoint label to the remote write metrics
#38397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rite metrics. It is often useful to know which endpoint are the metrics referring to directly, whilst this is something that an operator can infer by looking at the configuration it is often the case that there's no direct access to it. In the documentation, I don't see the endpoint being consider a secret so I reckon this is safe to do. Signed-off-by: gotjosh <josue.abreu@gmail.com>
|
This is a follow up from #37912 where I was asked by @ArthurSens to pull in a separate PR. There are two relevant conversations: |
Signed-off-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
ArthurSens
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is often useful to know which endpoints the metrics are referring to directly, whilst this is something that an operator can infer by looking at the configuration, it is often the case that there's no direct access to it.
In the documentation, I don't see the endpoint being considered a secret so I reckon this is safe to do.
Link to tracking issue
This technically a prequite for the work that I'm about to do as part of open-telemetry/opentelemetry-collector#12255 but is not directly related and can go individually.