Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] reduce API exposed by vcenterreceiver #38403

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Mar 5, 2025

Unexport structs, funcs and constants that should not be exposed outside the module.

@atoulme atoulme requested a review from a team as a code owner March 5, 2025 19:26
@atoulme atoulme requested a review from dashpole March 5, 2025 19:26
@github-actions github-actions bot requested review from schmikei and StefanKurek March 5, 2025 19:27
@atoulme
Copy link
Contributor Author

atoulme commented Mar 6, 2025

Maybe I need an API changelog here. I am not sure. Still waiting for codeowners to review first.

@atoulme
Copy link
Contributor Author

atoulme commented Mar 7, 2025

@schmikei @StefanKurek please review

Copy link
Contributor

@StefanKurek StefanKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me

@atoulme atoulme merged commit 818dc95 into open-telemetry:main Mar 10, 2025
171 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants