feat(telemetrygen): support integer attributes in telemetrygen tool (… #38410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomofeltrin
requested review from
mx-psi,
codeboten and
a team
as code owners
MovieStoreGuy
approved these changes
Mar 6, 2025
andrzej-stencel
added
the
ready to merge
mx-psi
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Could you add a changelog entry? This is the changelog process
andrzej-stencel
removed
the
ready to merge
codeboten
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Thanks for the PR @giacomofeltrin! Please add a test to validate int input works as expected. An example of this is the PR to add support for bool value types: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34558/files#diff-c4ca8592f264dfa745089fe14367c03ab5e87693bfacf4c1aaf6b80c47023be5
atoulme
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#38392)
Description
Introduced support for integer attributes in the
telemetrygentool. Previously, the tool required all telemetry attribute values to be strings wrapped in double quotes, which limited the ability to generate realistic test data with integer values. This change extends the existing attribute handling to correctly process integer values. The--telemetry-attributesflag now supports both quoted string values and unquoted integer values.Link to tracking issue
Fixes [#38392]
Documentation
Updated documentation for the
--telemetry-attributesflag to reflect the new support for integer attributes and provide examples of both string and integer usage.