kafkatopicsobserver: remove session_timeout and heartbeat_interval config #38414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
kafkatopicsobserver-rm-consumerconfig
branch
from
866ae6b to
9763156
Compare
|
I don't know why |
MovieStoreGuy
approved these changes
Mar 6, 2025
atoulme
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
session_timeoutandheartbeat_intervalconfig from thekafkatopicsobserver. These configuration attributes are relevant only to Kafka consumers, which the observer is not - it only uses the admin client.Link to tracking issue
N/A
Testing
Updated unit tests
Documentation
Updated README