[pkg/ottl] Adapt time parsing error messages to include the ctime directives #38425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…rmat Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
github-actions
bot
requested review from
bogdandrutu,
edmocosta,
evan-bradley,
kentquirk and
TylerHelmuth
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
edmocosta
reviewed
Mar 11, 2025
This was referenced Mar 23, 2025
This was referenced Apr 15, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Moving to draft while you address the conflict and review, please mark ready for review once addressed. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
…ssages' into feat/35176/time-parse-error-messages
edmocosta
reviewed
May 27, 2025
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
edmocosta
approved these changes
May 28, 2025
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
…ectives (open-telemetry#38425) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adapts the `Time` function to check for `time.ParseError` errors. If such an error is received by the function, it wraps it into a custom error type in order to include the provided ctime layout string instead of the go-native layout string. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35176 <!--Describe what testing was performed and which tests were added.--> #### Testing Adapted the unit tests of the `Time()` function --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts the
Timefunction to check fortime.ParseErrorerrors. If such an error is received by the function, it wraps it into a custom error type in order to include the provided ctime layout string instead of the go-native layout string.Link to tracking issue
Fixes #35176
Testing
Adapted the unit tests of the
Time()function