-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/header_setter] Expose auth attributes #38441
Merged
atoulme
merged 3 commits into
open-telemetry:main
from
jenrik:feature/headersetter-auth-attrs
Mar 12, 2025
Merged
[extension/header_setter] Expose auth attributes #38441
atoulme
merged 3 commits into
open-telemetry:main
from
jenrik:feature/headersetter-auth-attrs
Mar 12, 2025
+158
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Mar 7, 2025
atoulme
reviewed
Mar 7, 2025
atoulme
reviewed
Mar 7, 2025
atoulme
reviewed
Mar 7, 2025
extension/headerssetterextension/internal/source/attribute_test.go
Outdated
Show resolved
Hide resolved
Please add a changelog |
Allow settings header values based on authentication attributes
c24b9ef
to
c6b4dae
Compare
VihasMakwana
reviewed
Mar 7, 2025
atoulme
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes my summary review. Codeowners please review.
@VihasMakwana please review. |
VihasMakwana
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@atoulme it's good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
extension/headerssetter
ready to merge
Code review completed; ready to merge by maintainers
waiting-for-code-owners
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow settings header values based on authentication attributes
Testing
Documentation
Update extension README to explain
from_attribute