-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/prometheusremotewrite] feat: build prometheus unit and add to metadata in prometheusremotewr… #38444
Open
alexylew
wants to merge
4
commits into
open-telemetry:main
Choose a base branch
from
observeinc:alew/add-unit-to-prometheus-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[exporter/prometheusremotewrite] feat: build prometheus unit and add to metadata in prometheusremotewr… #38444
alexylew
wants to merge
4
commits into
open-telemetry:main
from
observeinc:alew/add-unit-to-prometheus-metadata
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @alexylew, thanks for your contribution! To be able to move this PR forward, please sign the CLA. |
yup working on getting the CLA signed, waiting for the CLA manager at my org to approve |
/fix:all |
@jmichalek132 or @dashpole if you have a chance to take a look at this PR that'd be much appreciated! This is my first contribution to opentelemetry so not super familiar with all the internal structure yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ite exporter
Description
This change adds the logic to convert an OTLP metric unit into the corresponding Prometheus metric unit. It will attempt to map UCUM units to Prometheus units where applicable. This change also extends the metadata emitted by the
prometheusremotewrite
exporter to include the newly calculated unit.Link to tracking issue
Fixes #29452
Testing
Added unit tests for the new
normalize_unit.go
file and also extended some existing unit tests to include more unit types.Documentation