awsfirehosereceiver: ignore CONTROL_MESSAGE log records #38445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the logs unmarshaller so it ignores CONTROL_MESSAGE CloudWatch log records, rather than returning an error.
edmocosta
reviewed
Mar 7, 2025
receiver/awsfirehosereceiver/internal/unmarshaler/cwlog/unmarshaler.go
Outdated
Show resolved
Hide resolved
edmocosta
approved these changes
Mar 10, 2025
Aneurysm9
approved these changes
Mar 11, 2025
edmocosta
added
ready to merge
atoulme
pushed a commit
that referenced
this pull request
Mar 11, 2025
#### Description I would like to become a codeowner of the awsfirehosereceiver. Elastic (where I work) intends to use this receiver heavily, and I would like to: - help spread out the maintenance load - ensure we have a path to progressing beyond the current Alpha stability Assuming open-telemetry/opentelemetry-collector#11864 goes through, it will be necessary to have multiple codeowners to progress to Beta and preferable to have codeowners from multiple employers, which is the case for @Aneurysm9 (AWS) and me (Elastic). Relevant changes: - #37111 (superseded by #37361) - #37262 - #37361 - #38388 (will extract from awsfirehosereceiver) - #38445 #### Link to tracking issue N/A #### Testing N/A #### Documentation N/A
songy23
removed
the
ready to merge
|
/label "ready to merge" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the CloudWatch logs unmarshaler so it ignores CONTROL_MESSAGE log records, rather than returning an error. As mentioned at https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/SubscriptionFilters.html, CONTROL_MESSAGE records are produced for health-checking the destination.
Link to tracking issue
Relates to #38433
(Not sure yet if it fixes it.)
Testing
Documentation
N/A