-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate/GitHub.com cloudfy azuremonitor 38432 #38450
base: main
Are you sure you want to change the base?
Renovate/GitHub.com cloudfy azuremonitor 38432 #38450
Conversation
9f3be64
to
e683e4c
Compare
e683e4c
to
743887c
Compare
CI will fail - see the cues in the build to address immediate issues. Thanks for the PR! |
Co-authored-by: Antoine Toulme <antoine@toulme.name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code review comments and addressed new review.
Thank you for your contributions! Since this change will affect current behaviour, my general feeling is to align with azure-sdk. + @pcwiese to take a look. |
@pcwiese - would live your view on this, and must admit @hgaol is right, behaviour will change as exception traces will be moved into exceptions table. If a limiting factor is important, might solve the breaking change by using a configuration parameter? Love you feedback, @hgaol thanks for highlight. |
Hi @cloudfy , here's the implementation in Azure Monitor OpenTelemetry Exporter .NET SDK for your reference. I think we'd better to align about handling log exception. |
@hgaol exactly - we've used the Azure SDK for logging before, but have to move to collector due to load. The collector however does not handle exceptions as the Azure SDK, which is why the PR (to align). I'll leave the team up to decide, but it does introduce a breaking change by handling exceptions into the right table. |
… This moves the classification away from SeverityNumber to follow the semantec model specification instead.
Description
This PR attempts to address a potential solution for issue #38432 by handling the state of logRecord when compared to the semantic model. Its my first PR to this project, please comments for feedback.
Link to tracking issue
Fixes: #38432
Testing
make
Documentation
Azure Monitor Exporter documentation is updated to reflect and include the description of exceptions handling.