node: fix test-net-server-listen-options-signal.js #17782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 9:13 PM PT - Feb 28th, 2025
✅ @Jarred-Sumner, your commit fb22d198c0e6c0e12a1f5e8c4f332de30d39de9b passed in 🧪 try this PR locally: bunx bun-pr 17782 |
nektro
commented
Mar 4, 2025
Comment on lines
+1533
to
+1537
| if (options?.signal === undefined) { | ||
| return; | ||
| } | ||
| validateAbortSignal(options.signal, "options.signal"); | ||
| const { signal } = options; |
There was a problem hiding this comment.
Suggested change
| if (options?.signal === undefined) { | |
| return; | |
| } | |
| validateAbortSignal(options.signal, "options.signal"); | |
| const { signal } = options; | |
| const signal = options?.signal; | |
| if (signal === undefined) return; | |
| validateAbortSignal(signal, "options.signal"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.