Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move JSValue.get to JSObject #17865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Mar 3, 2025

What does this PR do?

part of #15141

This lets us leverage the type system to only call .get on known JSObjects.

How did you verify your code works?

Existing tests cover all changes.

@DonIsaac DonIsaac requested a review from nektro March 3, 2025 02:03
@robobun
Copy link

robobun commented Mar 3, 2025

Updated 6:48 PM PT - Mar 2nd, 2025

@DonIsaac, your commit 4b30526 has 3 failures in Build #12588:


🧪   try this PR locally:

bunx bun-pr 17865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants