Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix concat DataFrame and Series with ignore_index=True #60983

Merged
merged 20 commits into from
Mar 7, 2025

Conversation

Anurag-Varma
Copy link
Contributor

@Anurag-Varma Anurag-Varma commented Feb 22, 2025

@Anurag-Varma Anurag-Varma marked this pull request as draft February 22, 2025 06:59
@Anurag-Varma Anurag-Varma marked this pull request as ready for review February 22, 2025 07:09
@Anurag-Varma Anurag-Varma marked this pull request as draft February 23, 2025 06:04
@Anurag-Varma Anurag-Varma marked this pull request as ready for review February 23, 2025 06:04
@Anurag-Varma
Copy link
Contributor Author

Hi @rhshadrach

Requesting a review as no reviewer is assigned to the PR

Thanks

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you add tests where the Series name is None and for axis=1.

@Anurag-Varma
Copy link
Contributor Author

Hi @rhshadrach I have done the requested changes from the review

@Anurag-Varma Anurag-Varma requested a review from rhshadrach March 6, 2025 01:35
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach changed the title Bug: fix Concatenating dataframe and series with ignore_index = True BUG: Fix concat DataFrame and Series with ignore_index=True Mar 6, 2025
@rhshadrach rhshadrach added the Bug label Mar 6, 2025
@rhshadrach rhshadrach added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Mar 6, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Mar 6, 2025
@mroeschke mroeschke merged commit bc24e84 into pandas-dev:main Mar 7, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @Anurag-Varma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
3 participants