Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Recognize chained fsspec URLs #61041

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Conversation

snitish
Copy link
Contributor

@snitish snitish commented Mar 3, 2025

The new (::[A-Za-z0-9+\-+.]+)* part of the regex will allow for optional ::<alphanumeric+-.>-like strings before the :// section of the URL, which will enable it to recognize chained fsspec URLs.

@mroeschke
Copy link
Member

Just confirming that there isn't a solution alluded to in #48978 (comment) where fsspec provides an API already to validate fsspec URLs?

@mroeschke mroeschke added the IO Network Local or Cloud (AWS, GCS, etc.) IO Issues label Mar 5, 2025
@snitish
Copy link
Contributor Author

snitish commented Mar 5, 2025

Just confirming that there isn't a solution alluded to in #48978 (comment) where fsspec provides an API already to validate fsspec URLs?

I checked the latest fsspec API reference and couldn't find any public functions for validating URLs.
https://filesystem-spec.readthedocs.io/en/latest/api.html

@mroeschke mroeschke added this to the 3.0 milestone Mar 5, 2025
@mroeschke mroeschke merged commit 9528057 into pandas-dev:main Mar 5, 2025
46 checks passed
@mroeschke
Copy link
Member

Thanks @snitish

@JMBurley
Copy link
Contributor

JMBurley commented Mar 5, 2025

Thanks @snitish!

I thought the bug was going to get closed the same week as when I documented the root cause and the bullet point solution. Took a few years in the end!

@ligon
Copy link

ligon commented Mar 5, 2025

Wow, I filed this bug in October 2022. I am super pleased to have it fixed. It would be churlish to complain about the amount of time it's taken--instead, I am just impressed by how inexorable progress seems to be!

@snitish
Copy link
Contributor Author

snitish commented Mar 6, 2025

Thanks @JMBurley for the outline you provided - it helped me fix this bug in no time.
@ligon glad I could be of help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Network Local or Cloud (AWS, GCS, etc.) IO Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Chained urls (allowed by fsspec) not recognized by is_fsspec_url
4 participants