Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake commit #484

Closed
wants to merge 2 commits into from
Closed

fake commit #484

wants to merge 2 commits into from

Conversation

bradyrx
Copy link
Collaborator

@bradyrx bradyrx commented Oct 8, 2020

Tests that pull_request_target runs tests from a forked PR.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Looks like uploading the coverage is breaking. Going to test that things are re-rendered on push anyways.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Okay pushing definitely re-renders tests. Want to make sure that the tests break since I changed one to break. They wouldn't break if it's just testing our master here (which happened with pull_request)

@aaronspring
Copy link
Collaborator

Seems not to fail...

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Seems not to fail...

Looks like checkout@v2 is checking out master instead of the forked version. Might need to just have in the PR template that we reference the forked github actions to assess tests. Which is not great since PRs will allow merging with broken tests since only RTD will trigger from forked PRs.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

actions/checkout#321

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Yeah the checkout action is pulling master from the forked branch. Need to somehow get it to checkout test_CI instead of master:

@bradyrx
Copy link
Collaborator Author

bradyrx commented Oct 8, 2020

Waiting on #485

@bradyrx bradyrx closed this Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants