Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: prefer Node.js built-in fs method #1089

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: rm file along with logging (do not iterate fs twice)
  • Loading branch information
SukkaW committed Sep 2, 2024
commit 3beb019422ca9e1697d0ded8ca37a898dfa90d84
1 change: 0 additions & 1 deletion src/git-utils.ts
Original file line number Diff line number Diff line change
@@ -30,7 +30,6 @@ export async function deleteExcludedAssets(destDir: string, excludeAssets: strin
return paths;
})();
const globber = await glob.create(excludedAssetPaths.join('\n'));
const files = await globber.glob();
for await (const file of globber.globGenerator()) {
core.info(`[INFO] delete ${file}`);
fs.rmSync(file, {recursive: true, force: true});
Loading
Oops, something went wrong.