Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]: Add support for custom TLS/SSL settings on Redis Adapter #16711

Closed
RayHughes opened this issue Mar 5, 2025 · 1 comment · Fixed by #16712
Closed

[NFR]: Add support for custom TLS/SSL settings on Redis Adapter #16711

RayHughes opened this issue Mar 5, 2025 · 1 comment · Fixed by #16712
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request

Comments

@RayHughes
Copy link

Is your feature request related to a problem? Please describe.
When using a self signed certificate, Redis requires either verification be turned off or a certificate provided on handshake. The current implementation does not support custom settings.

  'redis' => [
        'ssl' =>
            [
                'verify_peer' => false,
                'verify_peer_name' => false,
            ],
    ],

Unsupported Settings for the ssl configuration

  • verify_peer
  • verify_peer_name
  • local_cert
  • local_pk
  • cafile

Describe the solution you'd like
The unsupported SSL settings added to the the Redis Adapters.

Describe alternatives you've considered
As an alternative, I have created a custom adapter that invokes the client directly with custom configuration. However this solution does not use the phalcon AbstractAdapter classes.

@RayHughes RayHughes added the new feature request Planned Feature or New Feature Request label Mar 5, 2025
This was referenced Mar 5, 2025
@niden niden linked a pull request Mar 5, 2025 that will close this issue
5 tasks
@niden niden self-assigned this Mar 5, 2025
@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Mar 5, 2025
@niden niden added this to Phalcon v5 Mar 5, 2025
@niden niden moved this to In Progress in Phalcon v5 Mar 5, 2025
@niden
Copy link
Member

niden commented Mar 7, 2025

Resolved in #16712

Thank you @RayHughes

@niden niden moved this from In Progress to Implemented in Phalcon v5 Mar 7, 2025
@niden niden closed this as completed Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
Status: Implemented
Development

Successfully merging a pull request may close this issue.

2 participants