Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ESLint to v9 #709

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

chore: update ESLint to v9 #709

wants to merge 21 commits into from

Conversation

fisker
Copy link
Member

@fisker fisker commented Mar 3, 2025

No description provided.

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 59a815f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,5 +1,2 @@
{
"plugins": [
"@1stg/preset"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JounQin This cause lint script fails, maybe dependencies is outdated? Would you mind take a look? https://github.com/prettier/eslint-plugin-prettier/actions/runs/13671651574/job/38222988172#step:7:15

@fisker
Copy link
Member Author

fisker commented Mar 6, 2025

Need update Branch protection rule when merge.

@fisker fisker requested review from JounQin and BPScott March 6, 2025 13:17
@fisker fisker marked this pull request as ready for review March 6, 2025 13:17
@JounQin
Copy link
Member

JounQin commented Mar 6, 2025

Seems only housekeeping, but Node 14/16 compatible tests are disabled?

@fisker
Copy link
Member Author

fisker commented Mar 6, 2025

but Node 14/16 compatible tests are disabled?

ESLint can't run on them https://github.com/prettier/eslint-plugin-prettier/actions/runs/13699233561/job/38308655951#step:6:28 . Suggestion?

@JounQin
Copy link
Member

JounQin commented Mar 6, 2025

but Node 14/16 compatible tests are disabled?

ESLint can't run on them prettier/eslint-plugin-prettier/actions/runs/13699233561/job/38308655951#step:6:28 . Suggestion?

We may need to downgrade eslint to v8 for Node 14/16 on CI?

eslint-plugin-prettier@5 is compatible with eslint v8/v9, so testing is still needed just like prettier itself?

https://github.com/prettier/prettier/blob/main/.github/workflows/prod-test.yml#L61

@fisker
Copy link
Member Author

fisker commented Mar 6, 2025

We may need to downgrade eslint to v8 for Node 14/16 on CI?

I can try, but do we have a plan to drop support? Since I didn't actually change the code, it should still work with ESLint 8, just not tested.

@JounQin
Copy link
Member

JounQin commented Mar 6, 2025

I can try, but do we have a plan to drop support? Since I didn't actually change the code, it should still work with ESLint 8, just not tested.

Personally I'd follow prettier's strategy instead of eslint's.

What means when prettier changes its engines support, eslint-plugin-prettier will follow.

@fisker fisker marked this pull request as draft March 6, 2025 14:26
@fisker
Copy link
Member Author

fisker commented Mar 6, 2025

All tested.

@fisker fisker marked this pull request as ready for review March 6, 2025 15:17
@fisker fisker closed this Mar 6, 2025
@fisker fisker reopened this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants