-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update ESLint to v9 #709
base: main
Are you sure you want to change the base?
Conversation
|
@@ -1,5 +1,2 @@ | |||
{ | |||
"plugins": [ | |||
"@1stg/preset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JounQin This cause lint
script fails, maybe dependencies is outdated? Would you mind take a look? https://github.com/prettier/eslint-plugin-prettier/actions/runs/13671651574/job/38222988172#step:7:15
Need update Branch protection rule when merge. |
Seems only housekeeping, but Node 14/16 compatible tests are disabled? |
ESLint can't run on them https://github.com/prettier/eslint-plugin-prettier/actions/runs/13699233561/job/38308655951#step:6:28 . Suggestion? |
We may need to downgrade eslint to v8 for Node 14/16 on CI?
https://github.com/prettier/prettier/blob/main/.github/workflows/prod-test.yml#L61 |
I can try, but do we have a plan to drop support? Since I didn't actually change the code, it should still work with ESLint 8, just not tested. |
Personally I'd follow What means when |
All tested. |
No description provided.