test: migrate infer-plugins-ext-dir test cases

[43081j]

Pulls the infer-plugins-ext-dir tests from prettier.

[43081j]

@fabiospampinato this one seems like something we should discuss/decide before we merge these tests

it seems prettier treats *.foo as if it was **/*.foo, whereas we treat it as ./*.foo

i think we're correct, but this means a whole bunch of prettier configs may fail with our CLI. maybe we should do a special case that transforms "*.ext" into "**/*.ext"?

[fabiospampinato]

Yeah I think so, no need to break the world here. The problem is that this is a bit tricky, what is the actual logic that we want? Worth checking what v3 is actually doing, because there are many potential ways to implement something like this.

I imagine we should try to explode the glob and do something with that in some cases 🤔

I think we can skip this test for now and fix it later if it's the only blocker for this test suite.

Is everything else basically just copy/pasted?

[43081j]

Pretty much, just the paths changed to the mock/fixture extensions. The rest should be the same

[fabiospampinato]

What's the blocker for this PR, interpreting *.foo as if it was **/*.foo?

[43081j]

it should be good to merge and we can track the *.foo stuff separately

basically globs with no path are treated like **/{glob}. e.g. *.* is **/*.* in prettier. and *.js is **/*.js

[fabiospampinato]

So in order to select files actually matching *.js one has to write ./*.js?

[fisker]

I think treating *.js as **/*.foo idea comes from ESLint, but the link https://github.com/prettier/prettier/blob/de30788d30990b35534832ca554f5d5add2d4221/src/config/resolve-config.js#L105 is broken, so I'm not really sure.

[fabiospampinato]

@fisker presumably it isn't worth changing this, right? 🤔 how it works currently just seems incorrect to me, if I'm understanding it right.

[fabiospampinato]

@fisker random question, but if *.js is interpreted as **/*.js, how do we actually pick only the js files in the current directory? is ./*.js the answer?

[fisker]

I don't understand "pick", are we talking about files in overrides?

[43081j]

Basically I think a non relative wildcard would be assumed to mean ./.

So internally:

• * becomes ./**/*
• *.js becomes ./**/*.js
• foo becomes ./**/foo
• ./* is left as is
• **/*.js is left as is (isn't a standalone single *)

That would be like prettier right now I think