test: migrate plugin-options-string tests

[43081j]

Copies the tests from prettier.

Notable changes:

• A failed plugin load throws an uncaught exception before this change. This catches it and logs an error to stderr
• A snapshot-diff package was being used to create a git diff like diff as a jest snapshot. We can pick the unique lines out instead of using this

Skipped tests:

• --help {option} is not supported in prettier CLI
• --config-path with stdin is not yet supported (see Config resolution in stdin mode #21)

Notable hiccups:

• Parsing argv seems to fall over on things like --plugin=--foo--, so the test has been changed for now to use --plugin=totally-invalid

[fabiospampinato]

A snapshot-diff package was being used to create a git diff like diff as a jest snapshot. We can pick the unique lines out instead of using this

💯

Parsing argv seems to fall over on things like --plugin=--foo--, so the test has been changed for now to use --plugin=totally-invalid

That got fixed in the dependency that parses this stuff. Can you update the PR?

Let me know once the PR is ready to me merged, let's handle the stdin test later, it's tricky.

[43081j]

this should be all sorted now 👍

[fabiospampinato]

I'd like to change three things if you don't mind, if you can do them it'd be much quicker to merge this, or I can do these myself once I get a bit more time:

1. Can we have a getPluginOrExit utility function instead of hard-coding this in bin.ts?
2. Can we have a getPluginsOrExit that is basically the analogous of getPlugins, and use that instead?
3. I think we can keep getPlugin and getPlugins even if they are not used, for completeness.
4. snapshot-diff seems to approximately import the whole universe, so let's not use that, but in the original test we were also testing not only that the help text got updated, but also where the updates happened, and I think it'd be nice to be able to preserve testing for that 🤔 Not a blocker though.

[43081j]

i've added getPluginOrExit, but can you clarify what you mean for getPluginsOrExit? (plural)

at the minute we don't exit inside getPlugins since we must've already called getPluginOrExit when starting up

edit: weirdly the ci run complains about snapshots but i don't get that locally and have no changes

[fabiospampinato]

at the minute we don't exit inside getPlugins since we must've already called getPluginOrExit when starting up

Right but I don't think the code should be making that kind of assumption 🤔 better to be explicit about what we want, I think.

[fabiospampinato]

edit: weirdly the ci run complains about snapshots but i don't get that locally and have no changes

I forgot to update the snapshots, I didn't even notice that caused the jest to "fail". If you work now if you rebase.

[43081j]

should all be good again now 👍

[fabiospampinato]

snapshot-diff seems to approximately import the whole universe, so let's not use that, but in the original test we were also testing not only that the help text got updated, but also where the updates happened, and I think it'd be nice to be able to preserve testing for that 🤔 Not a blocker though.

It seems that we are not doing that 🤔 for now it's not a blocker, I'm merging, thanks 👍

[43081j]

I totally forgot about that comment, my bad. We can look into it in a separate PR 👍 Will probably need a text diff dependency