test: migrate plugin-resolution tests

[43081j]

Copies the plugin-resolution tests from prettier.

Blocked by #41

[fabiospampinato]

#41 got merged, can you rebase and check what else is needed?

[43081j]

@fabiospampinato this is blocked by #50

[43081j]

note these skipped tests too

prettier somehow allows foo/bar/baz.js to behave as if it was ./foo/bar/baz.js

no clue how it does this without just trying twice (once for a relative path, once for a node path, because it could also be from the package foo)

[fisker]

https://github.com/prettier/prettier/blob/af6e7215ce0e0d243cb34a85174af65ab4177f47/src/main/plugins/load-plugin.js#L20-L26

[43081j]

aha thank you. so it is what i expected

the question is, do we want this in the new CLI? its easy to add but maybe it'd be a good time to get rid of these relative-but-not-really-relative paths? and just tell people to use actual paths, like ./foo

[fisker]

Actually, I like how it works. Imagine if we support ignore files in config.

export default {
  ignore: [
-    "foo.js",
+    "./foo.js"
  ]
}

No body want this.

Same here

export default {
  plugins: [
-    "node_modules/prettier-plugin-foo/index.js",
+    "./node_modules/prettier-plugin-foo/index.js"
  ]
}

much easier to use.

Maybe someday, we should ask user to import plugin like ESLint did.

[fisker]

Add the plugin path also not related to config file, but related to CWD, makes no sense to put ./ there.

At least it's how it works now, in v3 I actually try to change it, but turns out it's harder than I thought, so I gave up.

[fisker]

Forgot details, but tricky part is here https://github.com/prettier/prettier/blob/af6e7215ce0e0d243cb34a85174af65ab4177f47/src/config/resolve-config.js#L67

[fabiospampinato]

Add the plugin path also not related to config file, but related to CWD, makes no sense to put ./ there.

@fisker wait, are you saying the plugin path should be resolved related to the CWD instead of the folder where the config is found in? Because I don't see v3 actually working like that.

[fabiospampinato]

#50 got fixed, do we need more changes to this PR before merging?