Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for objectWrap and experimentalOperatorPosition #48

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

fisker
Copy link
Member

@fisker fisker commented Feb 25, 2025

@fabiospampinato
Copy link
Collaborator

Thanks, I'm merging, but:

  1. If I'm seeing it right these options don't seem to be listed in the same spot as v3, presumably we want them to be listed in the same order.
  2. We need to update the normalizeOptions function to actually make use of these new options.
  3. We should update the type of the options object.
  4. We should probably have some tests that check that these options actually do something (as they currently don't, until normalizeOptions knows about them).
  5. Also I should have another look at the options listed in prettier_plugins_builtin.ts, I'm not sure we actually need those.

@fabiospampinato fabiospampinato merged commit 4513313 into main Mar 5, 2025
2 checks passed
@fabiospampinato
Copy link
Collaborator

Fixed #1, #2 and #3, if we want to make another release for these options we shooould be good to go.

@fisker fisker deleted the options branch March 6, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants