-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace 'yarn' with 'npm' #1250
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/5mFkRYxDxa2ANsdnixzCdFnLqeBd |
…peer-dep on React 16.x which conflicts with PRC’s peer-dep on React 17.x
…) has a peer-dep on React 16.x which conflicts with PRC’s peer-dep on React 17.x" This reverts commit e3612051ab01bf1dfbdf477f00ef96b0ea8aca47. Storybook has the same issue (storybookjs/storybook#14119, storybookjs/storybook#14619), so if we’re open to using '--legacy-peer-deps' to use Storybook, we can’t justify removing Playroom on anti-'--legacy-peer-deps' grounds.
…gically fix the 'svg-element-attributes'-related 'ERR_REQUIRE_ESM' error
I’m very surprised (since the
Fixed in 6bae722 |
From @smockle in #1250 (comment):
For (additional manual) verification (that is, beyond the automated verification from our test suite), I opened every PRC component page on https://primer-components-1dot5xcvk-primer.vercel.app/ (the latest Vercel deployment) and interacted with interactive elements demoed therein. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for making this transition! Can't wait for npm7 this fall 🚀
This PR migrates PRC workflows and scripts from
yarn
tonpm
(specifically, tonpm@6
). Public-facing docs continue to give usage examples with both tools, since our customers use both.Fixes https://github.com/github/primer/issues/179
Merge checklist